[
https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224414#comment-17224414
]
shuo li commented on THRIFT-5299:
---------------------------------
[~allengeorge] Correct, another workaround could be read u32 which not
zigzagged, then cast back to i32.
Actually, I think it is also a good idea to implement zigzag and varint in
thrift-rs. Other lang's implementation already did this. And we can remove one
dependency.
> rs implementation compact protocol seq_id should not use zigzag encoding.
> -------------------------------------------------------------------------
>
> Key: THRIFT-5299
> URL: https://issues.apache.org/jira/browse/THRIFT-5299
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
> Affects Versions: 0.13.0
> Reporter: shuo li
> Priority: Major
>
> While reviewing code, I discovered a bug in compact protocol.
> The seq_id in message header is decoded with integer-encoding's i32, which
> uses zigzag decode implicitly.
>
>
> EDIT: correct the title and desc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
