emmenlau opened a new pull request #2283:
URL: https://github.com/apache/thrift/pull/2283
This PR adds a few improvements in cmake dependency handling. Previously,
the cmake build did not pass dependencies so well downstream to dependent
projects. This PR ensures that all possible dependencies (including thriftz and
thriftnb) are passed correctly.
This PR also removes the find-script for libevent. Generally libevent can
nowadays often be found with the cmake config. However this may be a breaking
change(?)
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
