[
https://issues.apache.org/jira/browse/THRIFT-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284394#comment-17284394
]
Jens Geyer commented on THRIFT-5318:
------------------------------------
See https://github.com/php/php-src/blob/PHP-8.0.0/UPGRADING.INTERNALS
> PHP 8 compatible version of binary protocol
> -------------------------------------------
>
> Key: THRIFT-5318
> URL: https://issues.apache.org/jira/browse/THRIFT-5318
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Reporter: Tyler Christensen
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> PHP 8 has been released and [necessitates some
> changes|https://github.com/php/php-src/blob/PHP-8.0.0/UPGRADING.INTERNALS] to
> PHP extensions. In the case of thrift_protocol these changes are minor:
> * Update callsites of zend_call_method, zend_read_property, and
> zend_update_property
> * Add arginfo as requested by PHP 8 migration guide (supports reflection
> features)
> I believe it's possible to do these whilst retaining backwards compatibility
> with PHP 7; I'll open a PR on Github momentarily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
