[
https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287397#comment-17287397
]
Yuxuan Wang commented on THRIFT-5358:
-------------------------------------
To clarify, the lack of go.mod files does not break our users importing the go
library, it only breaks/blocks developers working on the library code.
As a result, combining with that the 2nd step is actually a lot of work, I
slightly prefer to skip this in 0.14.1.
But only adding the first one (lib/go/thrift/go.mod) into 0.14.1 will help
users importing the master branch version after that, because if we also do the
release process change in 0.14.1, they will get a pseudo v0.14.2-timestamp-sha1
version in their go.mod file, instead of v0.0.0-timestamp-sha1 version.
> Add go.mod file(s)
> ------------------
>
> Key: THRIFT-5358
> URL: https://issues.apache.org/jira/browse/THRIFT-5358
> Project: Thrift
> Issue Type: Task
> Components: Go - Library
> Affects Versions: 0.14.0
> Reporter: Yuxuan Wang
> Priority: Major
>
> Go 1.16 already disallowed building without go.mod file by default (still
> override-able with GO111MODULES=auto environment variable), and Go 1.17 will
> remove that override option, so we need to add go.mod file(s) to unblock
> developers working on tip and using Go 1.16+.
> Based on the current discussion on https://github.com/golang/go/issues/34055,
> we probably will need to add 2 go.mod files:
> # one under lib/go/thrift for our users to use. A release process change is
> also required because of this file: for all the future releases, we would
> need to double tag with "lib/go/thrift/" prefix (e.g. for 0.15.0 release we
> would need to git tag "v0.15.0" and "lib/go/thrift/v0.15.0" on the same
> commit)
> # another under root for the tests to work on Go 1.16+
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
