You are right. -w is supposed to stop compilation but it looks like -wi overrides that and just prints informational messages. I haven't been able to reproduce the build failure so far, but I did submit a pull request to fix the deprecation warnings. With any luck, that will hopefully fix the issue.
Thanks, James On Tue, Mar 23, 2021 at 1:09 PM Yuxuan Wang <[email protected]> wrote: > If that's the case those should fail consistently, which doesn't seem to be > the case (I do see those pass in some runs). > > On Tue, Mar 23, 2021 at 1:01 PM James Lacey <[email protected]> wrote: > > > I believe the -w flag is treating those deprecation warnings as errors > and > > is stopping the compilation. One way of fixing it would be to only pass > the > > -wi flag instead of -w. Of course, the better way would be to fix the > > warnings themselves. I will take a look and see if I can come up with a > PR > > that fixes it. > > > > Thanks, > > James > > > > > On Mar 23, 2021, at 12:22 PM, Yuxuan Wang <[email protected] > .invalid> > > wrote: > > > > > > I have seen this travis failures happen randomly several times now. It > > seem > > > to always fail from lib/src/d/test but looking at the log in travis > it's > > > not obvious to me what exactly caused the failure: > > > > > > make[2]: Leaving directory '/thrift/src/lib/nodejs' > > > dmd -L-fuse-ld=gold -L-levent ../libthriftd-event.a -L-fuse-ld=gold > > -L-lssl > > > -L-lcrypto ../libthriftd-ssl.a -w -wi -O -release -inline > > > -I../../../lib/d/src -Igen-d ../../../lib/d/libthriftd.a > > > -ofthrift_test_client thrift_test_client.d thrift_test_common.d > > > gen-d/thrift/test/SecondService.d gen-d/thrift/test/ThriftTest.d > > > gen-d/thrift/test/ThriftTest_constants.d > > > gen-d/thrift/test/ThriftTest_types.d > > > thrift_test_client.d(138): Deprecation: struct `std.datetime.StopWatch` > > is > > > deprecated - Use std.datetime.stopwatch.StopWatch. > > > thrift_test_client.d(138): Deprecation: struct `std.datetime.StopWatch` > > is > > > deprecated - Use std.datetime.stopwatch.StopWatch. > > > thrift_test_client.d(348): Deprecation: struct `std.datetime.StopWatch` > > is > > > deprecated - Use std.datetime.stopwatch.StopWatch. > > > thrift_test_client.d(348): Deprecation: alias `std.datetime.AutoStart` > is > > > deprecated - Use std.datetime.stopwatch.AutoStart. > > > thrift_test_client.d(348): Deprecation: struct `std.datetime.StopWatch` > > is > > > deprecated - Use std.datetime.stopwatch.StopWatch. > > > dmd -L-fuse-ld=gold -L-levent ../libthriftd-event.a -L-fuse-ld=gold > > -L-lssl > > > -L-lcrypto ../libthriftd-ssl.a -w -wi -O -release -inline > > > -I../../../lib/d/src -Igen-d ../../../lib/d/libthriftd.a > > > -ofthrift_test_server thrift_test_server.d thrift_test_common.d > > > test_utils.d gen-d/thrift/test/SecondService.d > > > gen-d/thrift/test/ThriftTest.d gen-d/thrift/test/ThriftTest_constants.d > > > gen-d/thrift/test/ThriftTest_types.d > > > make[3]: Leaving directory '/thrift/src/lib/d/test' > > > make[2]: Leaving directory '/thrift/src/lib/d' > > > make[1]: Leaving directory '/thrift/src/lib' > > > The command "build/docker/run.sh" exited with 2. > > > > > > An example travis run is > > > https://travis-ci.org/github/apache/thrift/jobs/764130681 > > > > > > Does anyone know what's the issue? > > >
