axeljaeger-arculus opened a new pull request #2386: URL: https://github.com/apache/thrift/pull/2386
…n TypeScript. Client: node,js <!-- Explain the changes in the pull request below: --> Add ? behind optional members in classes if the field is marked as optional in thrift-idl. Closes THRIFT-3508 and makes THRIFT-3227 probably obsolete as optional class members are supported since TypeScript 2.0 <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) No, I am hijacking the existing Ticket of THRIFT-3508 as it is exactly what I implemented. - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? Yes - [x] Did you squash your changes to a single commit? (not required, but preferred) Yes - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? Yes, I am not aware of braking changes, but was unable to to do the Test drive development approach from the provided documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
