TeinRnD opened a new pull request #2517: URL: https://github.com/apache/thrift/pull/2517
…endTimeout is checked. Client: netstd <!-- Explain the changes in the pull request below: --> The Read/Write operations on the TCP-stream are now blocking calls wrapped in a Task. This ensures the Send/ReceiveTimeout properties of the TcpClient are used. It is important that the (TSocket)Transport is closed/disposed when this exception is thrown. Otherwise the next Read operation will read the message that is sent after the timeout in the stream. Imo this is not a breaking change because this is the desired behavior. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
