tokcum opened a new pull request #2545:
URL: https://github.com/apache/thrift/pull/2545
Client: rs
The Thrift crate does not support Unix Domain Sockets (UDS). After reviewing
and expressing my thoughts on THRIFT-5283, I added support for UDS.
This is not a breaking change. Inspired by how actix_web::HttpServer
supports UDS, I added an additional fn to listen to UDS. I reorganized some
other existing code to be able to reuse it for UDS. I also had to implement the
trait TIoChannel for UnixStream. This went to transport::socket.
As UnixStream is only available on Unix, I tagged the code with
#[cfg(unix)]. I also cross compiled lib/rs to Windows with the following cargo
targets:
i686-pc-windows-gnu
i686-pc-windows-msvc
x86_64-pc-windows-gnu
x86_64-pc-windows-msvc
Last but not least I ran the rust <-> rust test harnesses as well as the
cross test harnesses. This looks good. At least, my contribution didn't
introduce new fails.
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
-> already existed as THRIFT-5283
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes?
-> not a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
