konpeki622 opened a new pull request #2547: URL: https://github.com/apache/thrift/pull/2547
<!-- Explain the changes in the pull request below: --> Related to [THRIFT-5535](https://issues.apache.org/jira/browse/THRIFT-5535). In a word, I modified `lib/nodejs/lib/thrift/http_connection.js` to support OpenHarmony OS data request [API](https://developer.harmonyos.com/en/docs/documentation/doc-references/js-apis-net-http-0000001168304341#section24678814124). > Maybe what you propose fits better under /contrib than in the general library. OpenHarmony OS supports importing node.js module as dependency, and that this module required other node.js modules such as `TJSONProtocol`, so I still do that under nodejs lib. It's hard to write test use case, but I created a [demo](https://github.com/konpeki622/openHarmony-thrift-demo) for test. You can try it with `npm link`. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
