[ 
https://issues.apache.org/jira/browse/THRIFT-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liu Jiayu updated THRIFT-5545:
------------------------------
    Description: 
Currently the directory layout of `lib/java` is:

❯ tree -L 2
.
├── CMakeLists.txt
├── Makefile.am
├── Makefile.in
├── README.md
├── android
│   ├── build.gradle
│   ├── settings.gradle
│   └── src
├── build.gradle
├── code_quality_tools
│   └── findbugs-filter.xml
├── coding_standards.md
├── gradle
│   ├── additionalArtifacts.gradle
│   ├── cloverCoverage.gradle
│   ├── codeQualityChecks.gradle
│   ├── environment.gradle
│   ├── functionalTests.gradle
│   ├── generateTestThrift.gradle
│   ├── publishing.gradle
│   ├── sourceConfiguration.gradle
│   ├── unitTests.gradle
│   └── wrapper
├── gradle.properties
├── gradlew
├── gradlew.bat
├── settings.gradle
├── src
│   └── org
└── test
    ├── org
    └── resources

With a customized gradle config but in fact we can adjust it to the 
conventional setup:

❯ tree -L 2
.
├── CMakeLists.txt
├── Makefile.am
├── Makefile.in
├── README.md
├── android
│   ├── build.gradle
│   ├── settings.gradle
│   └── src
├── build.gradle
├── code_quality_tools
│   └── findbugs-filter.xml
├── coding_standards.md
├── gradle
│   ├── additionalArtifacts.gradle
│   ├── cloverCoverage.gradle
│   ├── codeQualityChecks.gradle
│   ├── environment.gradle
│   ├── functionalTests.gradle
│   ├── generateTestThrift.gradle
│   ├── publishing.gradle
│   ├── sourceConfiguration.gradle
│   ├── unitTests.gradle
│   └── wrapper
├── gradle.properties
├── gradlew
├── gradlew.bat
├── settings.gradle
└── src
    ├── main
    └── test

 

i.e. `src/\{main,test}/\{java,resources}` so we can remove the customizations.

> Follow newer gradle convention in organizing source code directories
> --------------------------------------------------------------------
>
>                 Key: THRIFT-5545
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5545
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>            Reporter: Liu Jiayu
>            Priority: Minor
>
> Currently the directory layout of `lib/java` is:
> ❯ tree -L 2
> .
> ├── CMakeLists.txt
> ├── Makefile.am
> ├── Makefile.in
> ├── README.md
> ├── android
> │   ├── build.gradle
> │   ├── settings.gradle
> │   └── src
> ├── build.gradle
> ├── code_quality_tools
> │   └── findbugs-filter.xml
> ├── coding_standards.md
> ├── gradle
> │   ├── additionalArtifacts.gradle
> │   ├── cloverCoverage.gradle
> │   ├── codeQualityChecks.gradle
> │   ├── environment.gradle
> │   ├── functionalTests.gradle
> │   ├── generateTestThrift.gradle
> │   ├── publishing.gradle
> │   ├── sourceConfiguration.gradle
> │   ├── unitTests.gradle
> │   └── wrapper
> ├── gradle.properties
> ├── gradlew
> ├── gradlew.bat
> ├── settings.gradle
> ├── src
> │   └── org
> └── test
>     ├── org
>     └── resources
> With a customized gradle config but in fact we can adjust it to the 
> conventional setup:
> ❯ tree -L 2
> .
> ├── CMakeLists.txt
> ├── Makefile.am
> ├── Makefile.in
> ├── README.md
> ├── android
> │   ├── build.gradle
> │   ├── settings.gradle
> │   └── src
> ├── build.gradle
> ├── code_quality_tools
> │   └── findbugs-filter.xml
> ├── coding_standards.md
> ├── gradle
> │   ├── additionalArtifacts.gradle
> │   ├── cloverCoverage.gradle
> │   ├── codeQualityChecks.gradle
> │   ├── environment.gradle
> │   ├── functionalTests.gradle
> │   ├── generateTestThrift.gradle
> │   ├── publishing.gradle
> │   ├── sourceConfiguration.gradle
> │   ├── unitTests.gradle
> │   └── wrapper
> ├── gradle.properties
> ├── gradlew
> ├── gradlew.bat
> ├── settings.gradle
> └── src
>     ├── main
>     └── test
>  
> i.e. `src/\{main,test}/\{java,resources}` so we can remove the customizations.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to