SvenRoederer opened a new pull request, #2999:
URL: https://github.com/apache/thrift/pull/2999
Based on Thrift5794 I worked on improving CI-testing for netstd. As
sideeffect I found, that the thrift-exe is not found on windows, which is fixed
by commit
* "make MSBuild ignore errors when thrift-binary is not found and continue
search"
* "include .exe extension, when looking for compiler"
To address Thrift5794 this PR switches to use default C# languagelevel for
the `Thrift.PublicInterfaces.Compile.Tests` (dropping "net8" option from
calling the compiler). To keep testing with "net8 / C#12" a 2nd project
`Thrift.PublicInterfaces.Compile-C#12.Tests` is added, which keeps using the
"net8" option.
The Thrift-files are shared between both projects, to reduce amount of
duplicated code.
---
Alternative ways I tried/had in mind:
* generating code for all language-levels inside one project (generate to
different folders inside the project): will not work, as it causes double
definitions of generated symbols
* having the test-job changing the code to run for all language-levels:
feels ugly and hard to follow. Github tests can for sure do this way, but might
be pain when testing locally. (something like "for {default|net6|net8} in LANG:
sed /var/$LANG/ *.cssproj")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
