[
https://issues.apache.org/jira/browse/THRIFT-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868466#comment-17868466
]
Duru Can Celasun commented on THRIFT-5800:
------------------------------------------
Unconditional failure might break a lot of build scripts out there. +1 for
-strict though.
> "Could not find include file foo.thrift" probably should be failure instead
> of warning
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-5800
> URL: https://issues.apache.org/jira/browse/THRIFT-5800
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Yuxuan Wang
> Priority: Major
>
> Currently when a thrift file includes a non-exist file and don't reference it
> in any way otherwise, like this:
> {code}
> include "foo.thrift" // does not exist
> ... // don't reference anything that's foo.*
> {code}
> The compiler will generate a warning:
> {code}
> [WARNING:/path/to/file.thrift:N] Could not find include file foo.thrift
> {code}
> This probably should be failure instead of warning? Or at least be a failure
> when -strict arg is passed in, and keep at warning without -strict.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
