bjosv opened a new pull request, #3074:
URL: https://github.com/apache/thrift/pull/3074

   Client: Erlang
   Since [erlfmt](https://github.com/WhatsApp/erlfmt/releases/tag/v1.5.0) is a 
build dependency, and the currently used version generates build warnings with 
latest OTP 27, we lift its version.
   
   Example of warnings that are fixed:
   ```
   ===> Compiling erlfmt
       ┌─ _build/default/plugins/erlfmt/src/erlfmt_parse.yrl:
       │
    96 │  node -> standalone_exprs exprs dot : {exprs, (?range_anno('$1', 
'$3'))#{dot => true}, '$2'}.
       │                                                                        
╰── Warning: expression updates a literal
   
        ┌─ _build/default/plugins/erlfmt/src/erlfmt_parse.yrl:
        │
    149 │      {record, (?range_anno('$1', '$3'))#{macro_record => true}, '$1', 
[]}.
        │                                        ╰── Warning: expression 
updates a literal
   ...
   ```
   Includes a formatting correction (legacy) that is verified to work with the 
script `build/veralign.sh`.
   
   This change is additionally tested to work with older OTP 23 and 24.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to