cameron-martin opened a new pull request, #3083:
URL: https://github.com/apache/thrift/pull/3083
Client: nodejs
This adds a flag to the JS generator to output ES modules instead of
CommonJS. This is only valid when targeting node. A lot of the changes here are
to test this.
The `testAll.sh` script now generates an ES module version of the services
and types, and tests the client and the server with these. This has a few
knock-on effects. Firstly, any module that imports a generated ES module must
itself be an ES module, since CommonJS modules cannot import ES modules. ES
modules also do not support `NODE_PATH`, so instead the tests directory is
converted into a node package with a `file:` dependency on the root thrift
package.
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
