[ 
https://issues.apache.org/jira/browse/THRIFT-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923878#comment-17923878
 ] 

Jens Geyer commented on THRIFT-5849:
------------------------------------

Thanks for the explanation. 

{quote}Is this historical, where the implementations used to differ?{quote}
I did a quick look into source history and it pretty much seems to be that way. 
It started in THRIFT-1033 and all following patches simply followed the pattern.



> Expose createClient in browser version of nodejs package
> --------------------------------------------------------
>
>                 Key: THRIFT-5849
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5849
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>            Reporter: Cameron Martin
>            Priority: Major
>
> {{createClient}} is exposed in a nodejs context, but not for browsers. Even 
> though this is the same function as {{{}createWsClient{}}}, 
> {{{}createHttpClient{}}}, etc, it seems odd to use these for custom 
> connection types. Moreover, it is beneficial for the browser and nodejs 
> interface to be as similar as possible. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to