kpy3 opened a new pull request, #3122:
URL: https://github.com/apache/thrift/pull/3122
<!-- Explain the changes in the pull request below: -->
Another bunch of Erlang generator improvements. This time changes in type
and enum generation with some minor typos.
Changes:
- [x] Mark exception declaration with 'exception' in commentary
- [x] Mark enum declaration with 'unit' in commentary
- [x] Generate type for typedef declaration, use generated type instead of
base type in declaration
- [x] Generate type for enum values, type consist of declared values. Use
constant names in type declaration
- [x] Avoid integer type as enum value type, use generated type instead
- [x] Avoid magic numbers for enum as default values, use enum's constant
name instead
- [ ] Introduce nominal types (Erlang 28+)
- [ ] Generate specification for generated functions
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
