vyasr opened a new pull request, #3126: URL: https://github.com/apache/thrift/pull/3126
<!-- Explain the changes in the pull request below: --> This PR updates the minimum required version of CMake. This change is necessary because the CMake 4.0 release [removed policies that allowed supporting such old versions of CMake](https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features), so having such a low required minimum version of CMake prohibits using the latest versions. CMake 3.16 is already quite old (the release was [back in 2019](https://www.kitware.com/cmake-3-16-0-available-for-download/)) and it is a reasonable choice based on Linux distro support (for example, [it is the supported version for Ubuntu's 20.04 LTS release](https://packages.ubuntu.com/search?suite=focal&searchon=names&keywords=cmake)). I can mark this PR as breaking if desired, but I assume that in general breaking changes are reserved to indicate API/ABI/specification breaks, not changes to the build requirements. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
