Dear Carel,

On 11/17/25 06:59, Carel Combrink wrote:
And on the C++ side would really like to get this one done: "Unable to
build Thrift as a shared library on Windows"
https://issues.apache.org/jira/browse/THRIFT-5898
Your PR about GlobalOutput looks good to me, and I recently made similar
tests on my local branch successfully. However, the PR is not sufficient
for a shared library build, at least not on MSVC, because the library
does not export any symbols. Maybe I'm going into old news here?

In cmake, this could be combined with WINDOWS_EXPORT_ALL_SYMBOLS (see
https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html).
To continue automake support, one could also combine it with "real" export
macros like for example https://wiki.tcl-lang.org/page/DLLEXPORT+and+DLLIMPORT

Did you consider this?

All the best,

    Mario


Reply via email to