[
https://issues.apache.org/jira/browse/THRIFT-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5739.
--------------------------------
Fix Version/s: 0.23.0
Assignee: Z Yn
Resolution: Fixed
> set_nodelay should be enabled for TTcpChannel
> ---------------------------------------------
>
> Key: THRIFT-5739
> URL: https://issues.apache.org/jira/browse/THRIFT-5739
> Project: Thrift
> Issue Type: Improvement
> Components: Rust - Library
> Reporter: Z Yn
> Assignee: Z Yn
> Priority: Major
> Fix For: 0.23.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/thrift/blob/bc9c04d8049d7d5f5cf4e63a25226c1fb8c930bf/lib/rs/src/transport/socket.rs#L95]
>
> TCP_NODELAY is default false in rust tcp stream, while Nagle algorithm is
> usually not suitable for thrift.
>
> In golang, this is opened by default. For rust server and some other
> languages' client, it's already set true manually.
> [https://github.com/search?q=repo%3Aapache%2Fthrift+nodelay&type=pullrequests]
>
> Also, ruts client for gRPC enabled it.
> [https://github.com/hyperium/tonic/pull/120]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
