zsy056 opened a new pull request, #3257:
URL: https://github.com/apache/thrift/pull/3257
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
fix the following error
```
src\ext/endian.h(33): error C2375: 'ntohll': redefinition; different linkage
[C:\projects\build\MSVC2017\x64\lib\py\python_build.vcxproj]
C:\Program Files (x86)\Windows
Kits\10\include\10.0.18362.0\um\winsock2.h(1895): note: see declaration of
'ntohll'
c:\projects\thrift\lib\py\src\ext\binary.h(49): error C2065: 'ntohll':
undeclared identifier
[C:\projects\build\MSVC2017\x64\lib\py\python_build.vcxproj]
c:\projects\thrift\lib\py\src\ext\binary.h(49): error C2440: 'static_cast':
cannot convert from 'unsigned __int64 (__cdecl *)(unsigned __int64)' to
'int64_t' [C:\projects\build\MSVC2017\x64\lib\py\python_build.vcxproj]
c:\projects\thrift\lib\py\src\ext\binary.h(49): note: There is no context
in which this conversion is possible
c:\projects\thrift\lib\py\src\ext\binary.h(137): error C2065: 'ntohll':
undeclared identifier
[C:\projects\build\MSVC2017\x64\lib\py\python_build.vcxproj]
c:\projects\thrift\lib\py\src\ext\binary.h(137): error C2568: '=': unable to
resolve function overload
[C:\projects\build\MSVC2017\x64\lib\py\python_build.vcxproj]
c:\projects\thrift\lib\py\src\ext\binary.h(137): note: could be 'unsigned
__int64 ntohll(unsigned __int64)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
