kpumuk opened a new pull request, #3271: URL: https://github.com/apache/thrift/pull/3271
<!-- Explain the changes in the pull request below: --> When binary extensions are compiled and loaded, they replace Ruby implementation for some of of the core classes (structs, unions, and interestingly, compact protocol). This code is never tested when the binary extensions are present. For example, https://github.com/apache/thrift/pull/3269 provides a fix for one such discrepancy between native code and Ruby. This PR introduces one special "no extensions" build to test pure Ruby code. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-5909](https://issues.apache.org/jira/browse/THRIFT-5909) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
