kpumuk opened a new pull request, #3308: URL: https://github.com/apache/thrift/pull/3308
<!-- Explain the changes in the pull request below: --> While working on https://github.com/apache/thrift/pull/3307, I wanted to test Nonblocking server with cross tests and notice that Ruby integration test server does not support server type selection. C++ adds `--server-type` argument, and Python accepts it as positional. This change adds `--server-type` and allows to run cross tests with different server types. Unsurprisingly, cross-tests passed for framed transport and failed for buffered: https://github.com/kpumuk/thrift/actions/runs/22001432085/job/63575905711 (which is not compatible with nonblocking server). <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
