CJCombrink opened a new pull request, #3331:
URL: https://github.com/apache/thrift/pull/3331
<!-- Explain the changes in the pull request below: -->
Attempt to add UUID support for NodeTS and NodeJS
_Disclaimer: I don't develop in any one of these languages thus not sure if
what I have done is correct_
I still want to add nodejs and nodets in the cross tests but opening this so
long in the hope for directed feedback about what is done. I also need to
figure out what is needed to run these tests stand alone if anyone can assist
it will be appreciated
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-5924: UUID support for nodejs and
nodets](https://issues.apache.org/jira/browse/THRIFT-5924)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
