pkvach opened a new pull request, #3352: URL: https://github.com/apache/thrift/pull/3352
Running PHPUnit tests on PHP 8.5 produces deprecation warnings related to usage of `ReflectionProperty::setAccessible()`. Example failure: ``` PHP Deprecated: Method `ReflectionProperty::setAccessible()` is deprecated since 8.5, as it has no effect since PHP 8.1 ``` According to official PHP documentation, `ReflectionProperty::setAccessible()` is deprecated as of PHP 8.5 and has had no effect since PHP 8.1, where all properties are accessible by default. https://www.php.net/manual/en/reflectionproperty.setaccessible.php > [!NOTE] > This will not affect earlier PHP versions, meaning the changes are backward compatible. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
