srebhan opened a new pull request, #3428: URL: https://github.com/apache/thrift/pull/3428
PR #3381 introduced range checks for integer values, however, one of the checks fails with ``` # github.com/apache/thrift/lib/go/thrift /go/pkg/mod/github.com/apache/[email protected]/lib/go/thrift/framed_transport.go:206:12: math.MaxUint32 (untyped int constant 4294967295) overflows int ``` on 32-bit architectures because `math.MaxUint32` is of `untyped int` which is a **signed 32-bit** integer on those architectures and thus cannot hold the maximum 32-bit **unsigned** value. This PR fixes the issue by comparing the values as `uint64` values avoiding potential overflows. - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
