[
https://issues.apache.org/jira/browse/THRIFT-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-5961:
--------------------------------
> Migrate PHPUnit tests to attribute syntax
> -----------------------------------------
>
> Key: THRIFT-5961
> URL: https://issues.apache.org/jira/browse/THRIFT-5961
> Project: Thrift
> Issue Type: New Feature
> Components: PHP - Library
> Affects Versions: 0.24.0
> Reporter: Volodymyr Panivko
> Assignee: Volodymyr Panivko
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The PHP test suite at lib/php/test/ (59 Unit + 9 Integration files)
> uses annotation-style PHPUnit 9.5: @dataProvider, @test,
> @expectedException, @group, etc. PHPUnit 10 dropped annotation
> support; tests must use PHP 8 attributes (#[DataProvider], #[Test],
> #[Group]) before we can upgrade.
> This ticket converts every test file in lib/php/test/\{Unit,Integration}
> to attribute syntax:
> * @dataProvider Foo::bar -> #[DataProvider('bar')] (or
> #[DataProviderExternal(Foo::class, 'bar')])
> * @test -> #[Test]
> * @group foo -> #[Group('foo')]
> * @covers \Foo -> #[CoversClass(Foo::class)]
> * @before / @after -> #[Before] / #[After]
> Pure mechanical conversion; no behaviour change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
