[
https://issues.apache.org/jira/browse/THRIFT-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18077923#comment-18077923
]
Dmytro Shteflyuk commented on THRIFT-5969:
------------------------------------------
Definitely does not have to be default. I found some of the linters quite
helpful, starting with modernize and gosec (although, the latter might not be
as useful, given most of the errors are "integer overflow"). I would definitely
not enable it without any configuration, but having consistent formatting and
enforced code shape, especially in the age of auto-generated code, would be
beneficial for the codebase.
Currently, thrift codebase does not even respect default formatting for Golang,
meaning that saving a file in VS Code creates many unrelated formatting changes.
It is, of course, your decision :-) I can introduce the linter, but will not
insist if there is no interest - less work for me.
> Introduce golangci-lint for Go library
> --------------------------------------
>
> Key: THRIFT-5969
> URL: https://issues.apache.org/jira/browse/THRIFT-5969
> Project: Thrift
> Issue Type: Task
> Components: Go - Library
> Reporter: Dmytro Shteflyuk
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
