[
https://issues.apache.org/jira/browse/THRIFT-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18078253#comment-18078253
]
Yuxuan Wang edited comment on THRIFT-5969 at 5/4/26 4:56 PM:
-------------------------------------------------------------
1. You don't need golangci-lint to run go vet or staticcheck
2. If staticcheck has compatibility issues with new go release, I don't see how
golangci-lint can "fix" that
3. For modernize there's now built in `go fix` does it, but I looked at its
args and don't see a way to make it exit non-zero when there are things to fix,
so haven't added it to the workflow yet. And again, you don't need
golangci-lint to run it.
4. I disagree with a lot of the defaults from golangci-lint, so I'd rather add
tools we found useful individually.
was (Author: fishywang):
1. You don't need golangci-lint to run go vet not staticcheck
2. If staticcheck has compatibility issues with new go release, I don't see how
golangci-lint can "fix" that
3. For modernize there's now built in `go fix` does it, but I looked at its
args and don't see a way to make it exit non-zero when there are things to fix,
so haven't added it to the workflow yet. And again, you don't need
golangci-lint to run it.
4. I disagree with a lot of the defaults from golangci-lint, so I'd rather add
tools we found useful individually.
> Introduce gofmt for Go library
> ------------------------------
>
> Key: THRIFT-5969
> URL: https://issues.apache.org/jira/browse/THRIFT-5969
> Project: Thrift
> Issue Type: Task
> Components: Go - Library
> Reporter: Dmytro Shteflyuk
> Assignee: Yuxuan Wang
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
