sveneld opened a new pull request, #3453: URL: https://github.com/apache/thrift/pull/3453
## Summary Removes two dead pre-PSR-4 files from `lib/php/src/`: - **`lib/php/src/Thrift.php`** — defined global-namespace `TType`, `TMessageType`, `TException`, `TBase`, `TApplicationException`. Nothing loads it: composer's PSR-4 maps `Thrift\` → `lib/php/lib/`, and the PHP generator emits only `use Thrift\…` imports. The file's own tail does `include_once $GLOBALS['THRIFT_ROOT'].'/protocol/TProtocol.php'` and `/transport/TTransport.php` — paths that don't exist under `lib/php/src/`, so it would fatal if included. - **`lib/php/src/autoload.php`** — relies on PHP's `__autoload()`, removed in PHP 8.0 (`composer.json` requires `php ^8.1`). Its docblock still advertises a `--gen php:autoload` generator flag that no longer exists in `compiler/cpp/src/thrift/generate/t_php_generator.cc` (only `classmap` remains, and it targets namespaced `lib/php/lib/` classes). Both entries are also removed from `EXTRA_DIST` in `lib/php/Makefile.am`. The active PHP extension under `lib/php/src/ext/thrift_protocol/` is **untouched** — it is still built in CI and called via `function_exists(...)` from `TBinaryProtocolAccelerated` / `TBinarySerializer`. JIRA: https://issues.apache.org/jira/browse/THRIFT-5975 ## Checklist - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? — THRIFT-5975 - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? — yes; only unreachable / non-functional code is removed (the PSR-4 namespaced replacements have lived in `lib/php/lib/` for years) - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
