Jens-G opened a new pull request, #3468: URL: https://github.com/apache/thrift/pull/3468
## Summary - **`BoundaryValuesTest`** — replace three magic double literals (`1.7976931348623158e+308`, `2.2250738585072014e-308`, `2.2204460492503131e-16`) with `PHP_FLOAT_MAX`, `PHP_FLOAT_MIN`, and `PHP_FLOAT_EPSILON`. These named constants are available since PHP 7.2; because the minimum supported PHP version is now 8.1 the blocker no longer applies. The stale TODO comment is removed. - **`lib/php/README.md`** — the opening line still stated "Thrift requires PHP 7.1". Updated to 8.1 to match the actual minimum. - **`TSSLServerSocket`** — the `getSSLHost(string $host): string` method was previously public and part of the observable API. It was renamed to `private ensureSslHostPrefix()` without a deprecation period, silently breaking any subclass or call site that used it. A `@deprecated` public `getSSLHost()` shim is restored that delegates to the private method, with a notice that it will be removed in a future release. ## Test plan - [ ] `lib/php`: `composer install && vendor/bin/phpunit` - [ ] `make style` passes in `lib/php` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Generated-by: Claude Sonnet 4.6 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
