ctubbsii commented on code in PR #22:
URL: https://github.com/apache/thrift-website/pull/22#discussion_r3253338577
##########
.asf.yaml:
##########
@@ -31,12 +31,25 @@ github:
issues: false
projects: false
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
staging:
- profile: ~
- whoami: asf-staging
+ profile:
Review Comment:
This change doesn't matter. The tilde helps make it explicit, and protect
against typos or user confusion when the value is empty. I restored it to
minimize the pull request differences and to make it explicit, so it looks like
the asf.yaml example in the documentation. Discussion of this part of the PR is
a waste of time. Let's focus on the release tag naming conventions please.
That's the part that actually matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
