kpumuk opened a new pull request, #3494: URL: https://github.com/apache/thrift/pull/3494
<!-- Explain the changes in the pull request below: --> This change adds a keyword argument `client_timeout` to all server sockets: ```ruby # Default timeout is 5 seconds socket = Thrift::ServerSocket.new(1234) # Reduce the server timeout to 2.5 seconds socket = Thrift::ServerSocket.new(1234, client_timeout: 2.5) # Pass nil to remove the timeout, reverting to pre-0.24.0 behavior socket = Thrift::ServerSocket.new(1234, client_timeout: nil) ``` This is the first time Thrift Ruby library uses keyword arguments. The reason for this is to align with the upcoming switch of all public interfaces to keyword arguments, and better handle optional arguments (so you don't need to pass all other positional args to change the client timeout). <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-5949](https://issues.apache.org/jira/browse/THRIFT-5949) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
