kpumuk opened a new pull request, #3504: URL: https://github.com/apache/thrift/pull/3504
<!-- Explain the changes in the pull request below: --> Adding the default fallback service capability to multiplex processors as discussed after introducing the multiplex protocol in [THRIFT-1915](https://issues.apache.org/jira/browse/THRIFT-1915). ```ruby multiplexed_processor = Thrift::MultiplexedProcessor.new multiplexed_processor.register_default(MyService::LegacyProcessor.new(handler)) multiplexed_processor.register_processor('MyService', MyService::Processor.new(handler)) ``` This functionality is already present in Java, C++, Python, Go, Rust, Swift, Perl, Haxe, C GLib (but seem to be missing from NodeJS, .NET, PHP). It is also being tested by `multi*` family in cross-tests. Additionally, I removed the separate group for Ruby from cross-tests, as with UUID support implemented a while ago it is not longer needed. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6015](https://issues.apache.org/jira/browse/THRIFT-6015) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
