Marin Nozhchev created THRIFT-6042:
--------------------------------------
Summary: go: connection check should work for Windows
Key: THRIFT-6042
URL: https://issues.apache.org/jira/browse/THRIFT-6042
Project: Thrift
Issue Type: Improvement
Components: Go - Library
Affects Versions: 0.23.0
Reporter: Marin Nozhchev
As a follow-up to THRIFT-5996, I can extend the connection check initially
implemented for THRIFT-5214, to work on Windows. The Windows case is a bit more
complex, but the solution is still one screen of code. The complexity is worth
it, IMO, because the connection check is really valuable for use cases with
long-lived, sometimes idle, connections like the Go database/sql drivers. I
maintain a driver like that - [https://github.com/sclgo/impala-go] - so I'm
interested in solving this.
I'm happy to prepare a PR if you give me the go ahead. The code I intend to use
is at [https://github.com/murfffi/conncheck/blob/main/peek_windows.go] with
tests at [https://github.com/murfffi/conncheck/blob/main/conncheck_test.go] .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
