[
https://issues.apache.org/jira/browse/TIKA-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902369#action_12902369
]
Nick Burch commented on TIKA-486:
---------------------------------
Thanks for the patch and the files, it's true we hadn't considered
non-microsoft OLE2 files
The patch might want a few little tweaks to comments and if statement ordering
to make it clearer what's going on, but the basic logic looks sound. I'll apply
it with some tweaks in a few days, assuming no-one beats me to it!
> ContainerAwareDetector doesn't support non-MSOffice files which use the same
> magic
> ----------------------------------------------------------------------------------
>
> Key: TIKA-486
> URL: https://issues.apache.org/jira/browse/TIKA-486
> Project: Tika
> Issue Type: Improvement
> Reporter: Antoni Mylka
> Attachments: test-documents.zip,
> tika-non-office-files-with-office-magic.patch
>
>
> There are many applications which use the MSOffice magic number. I know of
> Corel Presentations X3, Corel Quattro Pro 7 and X3 and Microsoft Works Word
> Processor. They have their own mime types.
> They aren't properly supported by POI though which means that if the
> ContentAwareDetector finds such a file, it will resort to the
> POIFSContainerDetector and return the basic application/x-tika-msoffice file
> type because POI won't be able to say anything more specific. This will
> happen even in situations when the fallback detector might come up with a
> better answer.
> That's why IMHO the fallback detector should be used if the
> POIFSContainerDetector returns x-tika-msoffice. If the fallback detector
> comes up with a more specific type - the more specific one should be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
