[ 
https://issues.apache.org/jira/browse/TIKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532489#comment-13532489
 ] 

Ray Gauss II commented on TIKA-775:
-----------------------------------

@Jukka, I'm new to {{InterruptedException}} but from what I've read it seems 
like it's thrown  when a request to stop the thread has been received, not 
necessarily when something went wrong.  So if I understand it correctly, 
throwing a {{TikaException}} would result in the possibility of a behavior 
where some code asks Tika to stop and Tika blows up with an exception rather 
than throwing an expected {{InterruptedException}} or setting the Thread's 
interrupt status.

@Nick, TXTParser seems pretty simple already, I'd hate to duplicate work.  The 
code is currently spread out just as you suggest, with {{ExternalEmbedder}} in 
core and {{ExternalEmbedderTest}} in parsers.
                
> Embed Capabilities
> ------------------
>
>                 Key: TIKA-775
>                 URL: https://issues.apache.org/jira/browse/TIKA-775
>             Project: Tika
>          Issue Type: Improvement
>          Components: general, metadata
>    Affects Versions: 1.0
>         Environment: The default ExternalEmbedder requires that sed be 
> installed.
>            Reporter: Ray Gauss II
>              Labels: embed, patch
>             Fix For: 1.3
>
>         Attachments: embed_20121029.diff, embed.diff, 
> tika-core-embed-patch.txt, tika-parsers-embed-patch.txt
>
>
> This patch defines and implements the concept of embedding tika metadata into 
> a file stream, the reverse of extraction.
> In the tika-core project an interface defining an Embedder and a generic sed 
> ExternalEmbedder implementation meant to be extended or configured are added. 
>  These classes are essentially a reverse flow of the existing Parser and 
> ExternalParser classes.
> In the tika-parsers project an ExternalEmbedderTest unit test is added which 
> uses the default ExternalEmbedder (calls sed) to embed a value placed in 
> Metadata.DESCRIPTION then verify the operation by parsing the resulting 
> stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to