[ 
https://issues.apache.org/jira/browse/TIKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086213#comment-14086213
 ] 

Tim Allison commented on TIKA-1380:
-----------------------------------

In POI 3.10-final, this particular attachment threw an OLE10NativeException so 
a RESOURCE_NAME_KEY was never set, and the X_file5 was generated in TikaCLI 
based on the file number and the EMBEDDED_RELATIONSHIP_ID.

With 3.11-beta1, this OLE10NativeException is not thrown.  I propose this 
simple modification:
{noformat}
                    if (ole.getLabel() != null) {
                        metadata.set(Metadata.RESOURCE_NAME_KEY, dir.getName() 
+ '/' + ole.getLabel());
                    }
{noformat}
this will go back to the old behavior of having clients responsible for naming 
files that have no RESOURCE_NAME_KEY.

How does that sound?

> Upgrade to Apache POI 3.11 beta 1
> ---------------------------------
>
>                 Key: TIKA-1380
>                 URL: https://issues.apache.org/jira/browse/TIKA-1380
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>    Affects Versions: 1.6
>            Reporter: Nick Burch
>             Fix For: 1.6, 1.7
>
>         Attachments: TIKA-1380.patch, TIKA-1380b.patch, TIKA-1380c.patch, 
> tika-commentstable-missing.diff
>
>
> All being well, in a week there'll be a new release of Apache POI available, 
> 3.11 beta 1
> This issue is to track the upgrade, any required changes, and fixing any 
> TODOs that this upgrade permits



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to