[ 
https://issues.apache.org/jira/browse/TIKA-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386746#comment-14386746
 ] 

Konstantin Gribov commented on TIKA-1587:
-----------------------------------------

LGTM. Commited with integration test trivial fix.

> ForkParser::setJavaCommand should take List<String>
> ---------------------------------------------------
>
>                 Key: TIKA-1587
>                 URL: https://issues.apache.org/jira/browse/TIKA-1587
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>    Affects Versions: 1.7
>            Reporter: Oleg Oshmyan
>         Attachments: TIKA-1587.patch
>
>
> ForkParser::setJavaCommand currently takes a string and splits it on 
> whitespace. This makes it impossible to use commands with paths that contain 
> spaces. In particular, it makes it impossible to reliably use 
> System.getProperty("java.home") in order to launch the same Java that the 
> current process is running in, because it might contain spaces. If it would 
> just take a List<String> and pass (a clone of) it directly to ProcessBuilder, 
> this wouldn't be a problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to