[
https://issues.apache.org/jira/browse/TIKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698848#comment-14698848
]
Nick Burch commented on TIKA-1710:
----------------------------------
At first glance, looks good on the code side, but epic! Only one slight nit-pic
- we generally try to avoid wildcard imports. If it's quick, any chance you
could re-do the patch with the standard charsets static imported without the
wildcard? (I think it's normally UTF8, just a few places with others)
> Replace usages of classes in org.apache.tika.io with current alternatives
> -------------------------------------------------------------------------
>
> Key: TIKA-1710
> URL: https://issues.apache.org/jira/browse/TIKA-1710
> Project: Tika
> Issue Type: Improvement
> Components: batch, cli, core, example, gui, parser, server,
> translation
> Reporter: Yaniv Kunda
> Priority: Minor
> Fix For: 1.11
>
> Attachments: TIKA-1710.patch
>
>
> Many of the classes in org.apache.tika.io were inlined from commons-io in
> TIKA-249, but these days most components use commons-io anyway, so in order
> to clean the dependencies on org.apache.tika.io in preparation of adding
> commons-io to tika-core, the following can be done:
> - Replace usages of classes in org.apache.tika.io within non-core components
> with the corresponding classes in commons-io
> - Replace usages of org.apache.tika.io.IOUtils.UTF_8 with
> java.nio.charset.StandardCharsets.UTF_8 (in all components, including
> tika-core)
> - Replace other uses of String encoding names of standard charsets with their
> corresponding Charsets instances from StandardCharsets (this is logically
> related to IOUtils as these constants should have been there as UTF_8 was
> before Java 7)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
