[
https://issues.apache.org/jira/browse/TIKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14722700#comment-14722700
]
Hudson commented on TIKA-1719:
------------------------------
SUCCESS: Integrated in tika-trunk-jdk1.7 #847 (See
[https://builds.apache.org/job/tika-trunk-jdk1.7/847/])
TIKA-1719: Utilize try-with-resources where it is trivial
Patch by Yaniv Kunda (jukka:
http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1700195)
* /tika/trunk/tika-app/src/main/java/org/apache/tika/cli/TikaCLI.java
* /tika/trunk/tika-app/src/main/java/org/apache/tika/gui/TikaGUI.java
* /tika/trunk/tika-bundle/src/test/java/org/apache/tika/bundle/BundleIT.java
* /tika/trunk/tika-core/src/main/java/org/apache/tika/Tika.java
* /tika/trunk/tika-core/src/main/java/org/apache/tika/config/ServiceLoader.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/extractor/ParserContainerExtractor.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/extractor/ParsingEmbeddedDocumentExtractor.java
* /tika/trunk/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/io/LookaheadInputStream.java
* /tika/trunk/tika-core/src/main/java/org/apache/tika/io/TikaInputStream.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/language/LanguageIdentifier.java
* /tika/trunk/tika-core/src/main/java/org/apache/tika/parser/NetworkParser.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParser.java
*
/tika/trunk/tika-core/src/main/java/org/apache/tika/parser/external/ExternalParsersFactory.java
*
/tika/trunk/tika-core/src/test/java/org/apache/tika/TypeDetectionBenchmark.java
*
/tika/trunk/tika-core/src/test/java/org/apache/tika/io/TikaInputStreamTest.java
*
/tika/trunk/tika-core/src/test/java/org/apache/tika/language/LanguageIdentifierTest.java
*
/tika/trunk/tika-core/src/test/java/org/apache/tika/language/LanguageProfilerBuilderTest.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/ContentHandlerExample.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/EncryptedPrescriptionDetector.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/GrabPhoneNumbersExample.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/LazyTextExtractorField.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/LuceneIndexerExtended.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/MetadataAwareLuceneIndexer.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/ParsingExample.java
*
/tika/trunk/tika-example/src/main/java/org/apache/tika/example/TIAParsingExample.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/code/SourceCodeParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/crypto/Pkcs7Parser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/envi/EnviHeaderParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/gdal/GDALParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/html/HtmlParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/isatab/ISATabUtils.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iwork/IWorkPackageParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/jdbc/SQLite3DBParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mbox/MboxParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/AbstractPOIFSExtractor.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/ocr/TesseractOCRParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/RarParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/rtf/RTFObjDataParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/strings/StringsParser.java
*
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/txt/TXTParser.java
* /tika/trunk/tika-parsers/src/test/java/org/apache/tika/TestParsers.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/detect/TestContainerAwareDetector.java
* /tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/AutoDetectParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/ParsingReaderTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/chm/TestChmExtraction.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/chm/TestParameters.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/crypto/Pkcs7ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/dif/DIFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/dwg/DWGParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/envi/EnviHeaderParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/epub/EpubParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/executable/ExecutableParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/feed/FeedParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/font/FontParsersTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/hdf/HDFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/html/HtmlParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/ibooks/iBooksParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/isatab/ISArchiveParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/jdbc/SQLite3ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mail/RFC822ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mat/MatParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mbox/MboxParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/AbstractPOIContainerExtractionTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ExcelParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/OldExcelParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/OutlookParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/PowerPointParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ProjectParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/PublisherParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/TNEFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/VisioParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/WordParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/microsoft/ooxml/OOXMLParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp3/Mp3ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp4/MP4ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/netcdf/NetCDFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/ocr/TesseractOCRParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pdf/PDFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/ArParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/Bzip2ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/GzipParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/RarParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/Seven7ParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/TarParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/ZipParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/pkg/ZlibParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/prt/PRTParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/solidworks/SolidworksParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/strings/Latin1StringsParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/strings/StringsParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/txt/CharsetDetectorTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/xml/DcXMLParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/xml/EmptyAndDuplicateElementsXMLParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/xml/FictionBookParserTest.java
*
/tika/trunk/tika-parsers/src/test/java/org/apache/tika/sax/PhoneExtractingContentHandlerTest.java
*
/tika/trunk/tika-server/src/main/java/org/apache/tika/server/resource/TikaResource.java
*
/tika/trunk/tika-server/src/main/java/org/apache/tika/server/resource/UnpackerResource.java
> Utilize try-with-resources where it is trivial
> ----------------------------------------------
>
> Key: TIKA-1719
> URL: https://issues.apache.org/jira/browse/TIKA-1719
> Project: Tika
> Issue Type: Improvement
> Components: cli, core, example, gui, packaging, parser, server
> Reporter: Yaniv Kunda
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: easyfix
> Fix For: 1.11
>
> Attachments: TIKA-1719.patch
>
>
> The following type of resource usages:
> {code}
> AutoCloseable resource = ...;
> try {
> // do something with resource
> } finally {
> resource.close();
> }
> {code}
> {code}
> AutoCloseable resource = null;
> try {
> resource = ...;
> // do something with resource
> } finally {
> if (resource != null) {
> resource.close();
> }
> }
> {code}
> and similar constructs can be trivially replaced with Java 7's
> try-with-resource statement:
> {code}
> try (AutoCloseable resource = ...) {
> // do something with resource
> }
> {code}
> This brings more concise code with less chance of causing resource leaks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
