[
https://issues.apache.org/jira/browse/TIKA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074740#comment-15074740
]
Stefano Fornari edited comment on TIKA-1436 at 12/30/15 7:44 AM:
-----------------------------------------------------------------
Hi,
the conversation is what reported in the bug, in particular Jukka says "Yes,
the pattern is a bit awkward and generally shouldn't be recommended as it uses
an exception to control the flow of the program". Now, Yukka did not reply but
I provided a patch that addresses all Yukka concerns... and no one objected. I
do not know how to interpret it, but if this is not an agreement, I would ask
other developers on the list what they think. At the end, I can even give up.
The current code does not make much sense, frankly. If the dev team is fine
with it, then be it, but given that my patch is no such intrusive and results
in better code, I do not really see why all this resistance.
Let me know if you want me to provide a new patch or ask again on the list.
was (Author: stefanofornari):
Hi,
the conversation is what reported in the bug, in particular Jukka says "Yes,
the pattern is a bit awkward and generally shouldn't be
recommended as it uses an exception to control the flow of the program". Now,
Yukka did not reply but I provided a patch that addresses all Yukka concerns...
and no one objected. I do not know how to interpret it, but if this is not an
agreement, I would ask other developers on the list what they think. At the
end, I can even give up. The current code does not make much sense, frankly. If
the dev team is fine with it, then be it, but given that my patch is no such
intrusive and results in better code, I do not really see why all this
resistance.
Let me know if you want me to provide a new patch or ask again on the list.
> improvement to PDFParser
> ------------------------
>
> Key: TIKA-1436
> URL: https://issues.apache.org/jira/browse/TIKA-1436
> Project: Tika
> Issue Type: Improvement
> Components: parser
> Affects Versions: 1.6
> Reporter: Stefano Fornari
> Labels: parser, pdf
> Fix For: 1.12
>
> Attachments: ste-20140927.patch
>
>
> with regards to the thread "[PDFParser] - read limited number of characters"
> on Mar 29, I would like to propose the attached patch. I noticed that in Tika
> 1.6 there have been some work around a better handling of the
> WriteLimitReachedException condition, but I believe it could be even
> improved.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
