[ 
https://issues.apache.org/jira/browse/TIKA-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144903#comment-15144903
 ] 

Tim Allison edited comment on TIKA-1851 at 2/12/16 5:30 PM:
------------------------------------------------------------

bq. as long as we are not shipping test documents around with code then I am 
fully behind us obtaining consensus.

Done!

bq. In the case of the later perhaps integration tests requiring different 
combinations of documents would be better served in tika-app. 

Could we do those in tika-parsers, er, tika-test-resources?  

A proposal (is this the consensus for Step 1?):
# Move all test code out of test resources back to tika-core-tests
# Move test documents from monolithic directory to relevant modules
# Accept a very small amount of duplication of test documents (mostly between 
the package and office modules)

Step 2:
# Get rid of tika-parsers -- clear out the src/main directory: delete the 
Activator ([~bobpaulin], do I remember you saying we don't need this?) and move 
the DigestingParser to core (with a hit on adding a dependency in core on codec)
# Move all tests from tika-parsers to tika-test-resources



was (Author: talli...@mitre.org):
bq. as long as we are not shipping test documents around with code then I am 
fully behind us obtaining consensus.

Done!

bq. In the case of the later perhaps integration tests requiring different 
combinations of documents would be better served in tika-app. 

Could we do those in tika-parsers, er, tika-test-resources?  

A proposal (is this the consensus for Step 1?):
# Move all test code out of test resources back to tika-core-tests
# Move test documents back to relevant modules
# Accept a very small amount of duplication of test documents (mostly between 
the package and office modules)

Step 2:
# Get rid of tika-parsers -- clear out the src/main directory: delete the 
Activator ([~bobpaulin], do I remember you saying we don't need this?) and move 
the DigestingParser to core (with a hit on adding a dependency in core on codec)
# Move all tests from tika-parsers to tika-test-resources


> Tika 2.0 - Move test resources from core to test-resources
> ----------------------------------------------------------
>
>                 Key: TIKA-1851
>                 URL: https://issues.apache.org/jira/browse/TIKA-1851
>             Project: Tika
>          Issue Type: Sub-task
>            Reporter: Tim Allison
>            Assignee: Tim Allison
>            Priority: Trivial
>             Fix For: 2.0
>
>         Attachments: tika_2x_test_files_and_modules.xlsx
>
>
> Let's try to move resources that are used for testing to the test-resources 
> module if possible: MockParser, DummyParser, TikaTest and the unit tests for 
> MockParser.  That should also allow us to drop the test-jar goal in 
> tika-core.  Anything else?
> Haven't actually tried this yet; there may be surprises.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to