Hey Tim, I’ll take a look. Would be good to add the @AfterClass for sure though.
Cheers, Chris ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: [email protected] WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Director, Information Retrieval and Data Science Group (IRDS) Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA WWW: http://irds.usc.edu/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -----Original Message----- From: "Allison, Timothy B." <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Tuesday, March 22, 2016 at 6:55 PM To: "[email protected]" <[email protected]> Subject: Change to NER ParserTest re https://builds.apache.org/job/tika-2.x/57 >Chris et al, > > I wasn't able to replicate this test failure on Windows or rhel. My >_guess_ is that the OpenNLPNERecogniser is not actually being called, >only the Regex extractor. > > Is it possible that a different ordering of tests could land you in >NamedEntityParserTest's testParse with a >NamedEntityParser.SYS_PROP_NER_IMPL set to the Regex parser alone? > > I added an explicit setting of the OpenNLPNERecogniser in >testParse()...we'll see if that fixes it. If that does work, am I >masking something that you wanted to test for? > > Finally, should we add an @AfterClass clean up of the system property >to these tests so that we don't leave a residue of the tests set in the >system properties? > >Cheers, > > Tim > > > > >-----Original Message----- >From: Hudson (JIRA) [mailto:[email protected]] >Sent: Tuesday, March 22, 2016 3:03 PM >To: [email protected] >Subject: [jira] [Commented] (TIKA-1855) TIka 2.0 - Move shared test-code >back to tika-core and distribute test files to parser modules > > > [ >https://issues.apache.org/jira/browse/TIKA-1855?page=com.atlassian.jira.pl >ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207057#comm >ent-15207057 ] > >Hudson commented on TIKA-1855: >------------------------------ > >UNSTABLE: Integrated in tika-2.x #57 (See >[https://builds.apache.org/job/tika-2.x/57/]) >TIKA-1855 -- test file ending in .bin was git-ignored and fix (tallison: >rev 4390fba1317d5ee72af6a76f227311cc338043f5) >* >tika-test-resources/src/test/resources/test-documents/test-malformed-heade >r.html.bin >* >tika-app/src/test/java/org/apache/tika/embedder/ExternalEmbedderTest.java >* .gitignore > > >> TIka 2.0 - Move shared test-code back to tika-core and distribute test >>files to parser modules >> >>------------------------------------------------------------------------- >>--------------------- >> >> Key: TIKA-1855 >> URL: https://issues.apache.org/jira/browse/TIKA-1855 >> Project: Tika >> Issue Type: Sub-task >> Reporter: Tim Allison >> Assignee: Tim Allison >> >> Undo TIKA-1851, and divide test docs to appropriate parser modules. > > > >-- >This message was sent by Atlassian JIRA >(v6.3.4#6332)
