OK, I'll bring them back into o.a.tika.language tommorow if no objections will follow until tommorow.
I don't see any ways to break something by doing this but I will recheck it. Should I also enable clirr-maven-plugin on these classes? пн, 25 апр. 2016 г. в 20:39, Mattmann, Chris A (3980) < [email protected]>: > +1 I am fine with: > > 1. putting the old classes back in. Fine by me. > 2. keeping the new tika-langdetect and improvements. > > I think that this is the easiest. Sorry for breaking > the trunk, apologies. I was just eager to backport Ken’s > stuff and also to get Text.jl support. > > Let’s just add back LanguageIdentifier and I think that would > do it, right? > > Any objections? > > Cheers, > Chris > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Chris Mattmann, Ph.D. > Chief Architect > Instrument Software and Science Data Systems Section (398) > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > Office: 168-519, Mailstop: 168-527 > Email: [email protected] > WWW: http://sunset.usc.edu/~mattmann/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Director, Information Retrieval and Data Science Group (IRDS) > Adjunct Associate Professor, Computer Science Department > University of Southern California, Los Angeles, CA 90089 USA > WWW: http://irds.usc.edu/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > > > > > > > On 4/25/16, 12:56 PM, "Allison, Timothy B." <[email protected]> wrote: > > >+1 > > > >Thank you, Konstantin, for catching this. I agree about breaking changes > in trunk. > > > >Should we plop the old classes back where they were, add deprecation and > live with a bit of messiness for a few versions? > > > > > > > >-----Original Message----- > >From: Konstantin Gribov [mailto:[email protected]] > >Sent: Monday, April 25, 2016 10:50 AM > >To: [email protected] > >Subject: [DISCUSS] Backward compatibility > > > >Hi, folks. > > > >I want to bring our attention to maintaining backward compatibility on > master/1.x branch. I've recently found that we dropped > o.a.tika.language.LanguageIdentifier in 3a7a94c[1] (merged on 2016-03-07, > see [2] also). It will brake downstream dependants of `tika-core` which use > `LanguageIdentifier`. > > > >It looks OK in 2.x branch, but I'm against sudden API changes (especially > dropping public classes/interfaces) in 1.x branch. At least we should mark > it `@Deprecated` for version or couple before dropping. > > > >I'd like to bring this and related classes back before 1.13 release if > nobody objects to. I will haven't time to refactor it to use new APIs till > middle of May. > > > >[1]: > > > https://github.com/apache/tika/commit/3a7a94ca5040eabd90f6060effc517126def3fc1 > >[2]: https://issues.apache.org/jira/browse/TIKA-1723 > >-- > >Best regards, > >Konstantin Gribov > -- Best regards, Konstantin Gribov
