[
https://issues.apache.org/jira/browse/TIKA-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294197#comment-15294197
]
ASF GitHub Bot commented on TIKA-1980:
--------------------------------------
GitHub user naegelejd opened a pull request:
https://github.com/apache/tika/pull/121
fix for TIKA-1980 contributed by naegelejd
While this fixes TIKA-1980, which is regression I caused in TIKA-1938, it
might be good to have a second set of eyes make sure there isn't anything else
I should test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/naegelejd/tika TIKA-1980
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tika/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 6b45ced7da5f0ed881819eed82a618a9c18d4604
Author: Joseph Naegele <[email protected]>
Date: 2016-05-20T21:02:56Z
fix for TIKA-1980 contributed by naegelejd
----
> HTML head tags found after first script not parsed by HtmlParser (regression)
> -----------------------------------------------------------------------------
>
> Key: TIKA-1980
> URL: https://issues.apache.org/jira/browse/TIKA-1980
> Project: Tika
> Issue Type: Bug
> Components: parser
> Reporter: Joseph Naegele
> Attachments: head.html, testAllHeadElements.patch
>
>
> TIKA-1938 introduced a regression where HTML elements found within {{<head>}}
> after the first {{<script>}} element are "dropped".
> I've attached a patch that adds a JUnit test to
> {{tika-parsers/src/test/java/org/apache/tika/parser/html/HtmlParserTest.java}},
> and the corresponding test resource, which belongs at
> {{tika-parsers/src/test/resources/test-documents/head.html}}. The new test
> document is needed because it contains {{<script>}} elements before the
> {{<title>}} element and before some of the {{<meta>}} tags.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
