[
https://issues.apache.org/jira/browse/TIKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302610#comment-15302610
]
ASF GitHub Bot commented on TIKA-1978:
--------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/tika/pull/124
TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do
domain name resolution, in
org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) 2.x branch
This issue addresses https://issues.apache.org/jira/browse/TIKA-1978 for
the 2.x branch.
It also makes a number of additional improvements such as using the diamond
operator where possible, throwing and logging the correct exceptions and using
the correct syntax for constants.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/tika TIKA-1978v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tika/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit bd3ecfcddeaf13262e477ba29c5256ebd44e32db
Author: Lewis John McGibbney <lewis.mcgibb...@gmail.com>
Date: 2016-05-26T18:15:02Z
TIKA-1978 Invocation of java.net.URL.equals(Object), which blocks to do
domain name resolution, in
org.apache.tika.parser.geo.topic.GeoParser.initialize(URL) 2.x branch
----
> Invocation of java.net.URL.equals(Object), which blocks to do domain name
> resolution, in org.apache.tika.parser.geo.topic.GeoParser.initialize(URL)
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TIKA-1978
> URL: https://issues.apache.org/jira/browse/TIKA-1978
> Project: Tika
> Issue Type: Bug
> Components: parser
> Affects Versions: 1.13
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: 2.0, 1.14
>
>
> Performance - The equals and hashCode methods of URL are blocking
> The equals and hashCode method of URL perform domain name resolution, this
> can result in a big performance hit. See
> http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html
> for more information. Consider using java.net.URI instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
