[
https://issues.apache.org/jira/browse/TIKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332530#comment-15332530
]
Thamme Gowda commented on TIKA-1986:
------------------------------------
I too think {{DummyConfigurableParser}} and its tests can be removed as they
are redundant.
I just checked your commits on TIKA-1508 branch. You simplified it very well,
thank you :-)
My little concern is with the {{initialize()}} method of {{Initializable}}
interface.
For example, I have a parser {{ObjectRecognitionParser}} which internally uses
Tensorflow Image recogniser (you may treat it as an internal service for the
parser) to classify images.
I have exploited the runtime binding functionality to bind these params to the
inner services as well.
[Link to my pull request|
https://github.com/thammegowda/tika/blob/2a61205402c90fa49fbd4ee11c48cf7473aee07a/tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java#L94]
Now I see that with the newer design, we miss out that functionality!
Whats your opinion on changing {{initialize()}} to {{initialize(Map<String,
Param<?>> params)}} ? It may seem redundant at first sight, but I think binding
params to inner services is also a valid case :-) IMO Parser cannot anticipate
and declare all the parameters it's inner services accept!
> support parser parameters with type (int, double, etc) in configuration XML
> file
> --------------------------------------------------------------------------------
>
> Key: TIKA-1986
> URL: https://issues.apache.org/jira/browse/TIKA-1986
> Project: Tika
> Issue Type: Sub-task
> Components: config
> Reporter: Thamme Gowda
> Fix For: 1.14
>
>
> Tika Configuration should be enhanced to support for basic types like int,
> double, boolean, url, file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
