GitHub user ham1 opened a pull request:
https://github.com/apache/tika/pull/150
Fixed TesseractOCRConfigTest and some TesseractOCRConfig refactoring
I created a PR for a small bug in TesseractOCRConfig.java the other week,
and it's been merged (thanks). However, after looking at the tests they don't
seem to actually be able to detect errors; i.e. they still pass even if the
method rejects valid params.
I've re-written them but have some questions:
1. setResize(), the javadoc say "Valid range of values is 100-900." but the
code seems to be set up only to accept values to the nearest 100 i.e. 100, 200,
..., 800, 900.
Does anyone know if the current behaviour is intended?
2. setDensity(), the javadoc says 150-1200 but the [ImageMagick docs
mention
72-1200](https://www.imagemagick.org/script/command-line-options.php#density)
Which is 'correct'/intended?
Please let me know and I can then finish this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/tika tesseract-config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tika/pull/150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #150
----
commit c9dd869b6655fbf9984097d23204c994ad7418f9
Author: Graham Russell <[email protected]>
Date: 2017-01-18T21:47:39Z
Fixed TesseractOCRConfigTest and some TesseractOCRConfig refactoring
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
