[
https://issues.apache.org/jira/browse/TIKA-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012235#comment-16012235
]
Tim Allison edited comment on TIKA-2360 at 5/16/17 12:20 PM:
-------------------------------------------------------------
I removed the SentimentParser from SPI, removed glob detection for .sent, and
made the unit tests pass if there's an exception from the network call. I did
not swallow the exception on initialization. If someone wants the
SentimentParser and turns it on via config, they should know that it fails.
was (Author: [email protected]):
I removed the SentimentParser from SPI, removed glob detection for .sent, and
made the unit tests pass if there's an exception from the network call. I did
not swallow the exception on initialization. If someone wants the
SentimentParser and turns it on via config, they should know that it fails. We
should convert {{printStackTrace}}'s to log ... later...
> Handle SentimentParser resource failure more robustly
> -----------------------------------------------------
>
> Key: TIKA-2360
> URL: https://issues.apache.org/jira/browse/TIKA-2360
> Project: Tika
> Issue Type: Improvement
> Reporter: Tim Allison
> Priority: Blocker
> Fix For: 1.15
>
>
> The SentimentParser tests currently require a network call to github. For
> those working behind a proxy or would prefer Tika not to make unexpected
> network calls, can we please turn this off by default?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
