[
https://issues.apache.org/jira/browse/TIKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504245#comment-16504245
]
Robin Schimpf commented on TIKA-2446:
-------------------------------------
Thank you for the fix!
Looks like POI changed their implementation to use commons-compress recently.
Good to know they already fixed the problem.
> Tainted Zip file can provoke OOM errors
> ---------------------------------------
>
> Key: TIKA-2446
> URL: https://issues.apache.org/jira/browse/TIKA-2446
> Project: Tika
> Issue Type: Bug
> Affects Versions: 1.16
> Reporter: Thorsten Schäfer
> Priority: Major
> Fix For: 1.19, 2.0.0
>
> Attachments: corrupt_zip.zip
>
>
> Hi,
> using Tika 1.16 with embedded POI 3.17-beta1 we experienced an OutOfMemory
> error on a Zip file. The suspicious code is in the constructor of
> FakeZipEntry in line 125. Here a ByteArrayOutputStream of up to 2 GiB in size
> is opened which will most probably lead to an OutOfMemory. The entry size in
> the zip file can be easily faked by an attacker.
> The code path to FakeZipEntry will be used only if the native
> java.util.zip.ZipFile implementation already failed to open the (possibly
> corrupted) Zip. Possibly a more fine grained error analysis could be done in
> ZipPackage.
> I have attached a tweaked zip file that will provoke this error.
> {code:java}
> public FakeZipEntry(ZipEntry entry, InputStream inp) throws IOException {
> super(entry.getName());
>
> // Grab the de-compressed contents for later
> ByteArrayOutputStream baos;
> long entrySize = entry.getSize();
> if (entrySize !=-1) {
> if (entrySize>=Integer.MAX_VALUE) {
> throw new IOException("ZIP entry size is too large");
> }
> baos = new ByteArrayOutputStream((int) entrySize);
> } else {
> baos = new ByteArrayOutputStream();
> }
> {code}
> Kinds,
> Thorsten
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
